Hawk High

First Flight #39
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Impact: medium
Likelihood: low
Invalid

Unused return values

Summary

The contract includes external dependencies that ignore return values from important function calls, which leads to silent failures.

Vulnerability Details

These vulnerabilities are in the OpenZeppelin dependencies rather than the custom contract code:

  1. ERC1967Utils.upgradeBeaconToAndCall ignores the return value from Address.functionDelegateCall

  2. ERC1967Utils.upgradeToAndCall similarly ignores return values

Impact

These ignored return values result in silent failures during critical operations like contract upgrades. If the delegated calls fail, the contract might not register the failure, leading to an inconsistent state or even unexpected behavior.

Recommendations

Personally I would implement additional validation checks after these function calls and also I would add event logging to capture potential failures for off chain monitoring

Updates

Lead Judging Commences

yeahchibyke Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Too generic
yeahchibyke Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.