Submission Details
Severity:
Missing Verification of Four Reviews per Student Permits Premature Graduation
Summary
There is no check for all students have been reviewed 4 times before upgrading to LevelTwoimplementation in the LevelOne::graduateAndUpgradefunction.
Impact
With no check in graduateAndUpgradefunction leads to the possibility to upgrade to new implementaion before all students gets 4 reviews. This break a protocol invariant leading to not intended behavior of the contract.
Tools Used
Manual code review
Recommendations
Add a check in the graduateAndUpgradefunction:
+ error HH_StudentNotReviewed();
function graduateAndUpgrade(address _levelTwo, bytes memory) public onlyPrincipal {
if (_levelTwo == address(0)) {
revert HH__ZeroAddress();
}
+ uint256 totalStudents = listOfStudents.length;
+ for (uint256 n = 0; n < totalStudents; n++) {
+ address student = listOfStudents[n];
+ if (reviewCount[student] < 4) {
+ revert HH_StudentNotReviewed();
+ }
+ }
uint256 totalTeachers = listOfTeachers.length;
uint256 payPerTeacher = (bursary * TEACHER_WAGE) / PRECISION;
uint256 principalPay = (bursary * PRINCIPAL_WAGE) / PRECISION;
_authorizeUpgrade(_levelTwo);
for (uint256 n = 0; n < totalTeachers; n++) {
usdc.safeTransfer(listOfTeachers[n], payPerTeacher);
}
usdc.safeTransfer(principal, principalPay);
}
Updates
Lead Judging Commences
yeahchibyke about 2 months ago
Submission Judgement Published Assigned finding tags:
cut-off criteria not applied
All students are graduated when the graduation function is called as the cut-off criteria is not applied.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.