Submission Details
Impact:
Likelihood:
Empty graduate() Function Lacks Graduation Logic, Preventing Student Promotion
Summary
The LevelTwo::graduatefunction is empty and should be checking if students are above cutOffScoreand then graduate.
Impact
There is no logic in the contract that checks if students are above cutOffScorebreaking an invariant of the protocol.
Tools Used
Manual code review
Recommendations
Add this code to the graduatefunction:
+ mapping(address => bool) public graduated;
+ event StudentGraduated(address indexed student);
function graduate() public onlyPrincipal reinitializer(2) {
+ uint256 totalStudents = listOfStudents.length;
+ for (uint256 n = 0; n < totalStudents; n++) {
+ address student = listOfStudents[n];
+ // Check cutoff
+ if (studentScore[student] >= cutOffScore) {
+ graduated[student] = true;
+ emit StudentGraduated(student);
+ }
+ }
}
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.