Submission Details
Severity:
Principal can call `LevelOne::graduateAndUpgrade` before the session ends
Summary
Principal can call graduateAndUpgrade before the session ends, breaking one of the system's invariants
Impact
Breaks the system's invariant
Tools Used
Manual Review
Recommendations
Add a checker to ensure that graduateAndUpgrade can only be called after the session ends.
function graduateAndUpgrade(address _levelTwo, bytes memory) public onlyPrincipal {
+ require(block.timestamp >= sessionEnd, "Session has not ended yet");
if (_levelTwo == address(0)) {
revert HH__ZeroAddress();
}
uint256 totalTeachers = listOfTeachers.length;
uint256 payPerTeacher = (bursary * TEACHER_WAGE) / PRECISION;
uint256 principalPay = (bursary * PRINCIPAL_WAGE) / PRECISION;
_authorizeUpgrade(_levelTwo);
for (uint256 n = 0; n < totalTeachers; n++) {
//audit-high: you are giving each teacher 35% of the bursary!
usdc.safeTransfer(listOfTeachers[n], payPerTeacher);
}
usdc.safeTransfer(principal, principalPay);
}
Updates
Lead Judging Commences
yeahchibyke 3 months ago
Submission Judgement Published Assigned finding tags:
can graduate without session end
`graduateAndUpgrade()` can be called successfully even when the school session has not ended
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.