Hawk High

First Flight #39
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Impact: low
Likelihood: low
Invalid

Usage of Magic Numbers in `LevelOne::startSession` function

Summary

LevelOne::startSession function is using a magic number for school session duration.

Vulnerability Details

sessionEnd = block.timestamp + 4 weeks;

Recommendations

We can use a constant variable for storing the literal value.

- sessionEnd = block.timestamp + 4 weeks;
+ uint256 constant public SCHOOL_DURATION=4 weeks;
+ sessionEnd = block.timestamp + SCHOOL_DURATION;
Updates

Lead Judging Commences

yeahchibyke Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.