Submission Details
Impact:
Likelihood:
Usage of Custom Errors save gas Cost
Summary
LevelOne::giveReview function should use custom errors to save some gas cost
Vulnerability Details
require(reviewCount[_student] < 5, "Student review count exceeded!!!");
require(block.timestamp >= lastReviewTime[_student] + reviewTime, "Reviews can only be given once per week");
Impact
Not using Custom errors for checks increase the gas cost
Recommendations
- require(reviewCount[_student] < 5, "Student review count exceeded!!!");
- require(block.timestamp >= lastReviewTime[_student] + reviewTime, "Reviews can only be given once per week");
+ error HH__StudentReviewCountExceeded();
+ error HH__StudentGivenMoreThanOneReviewPerWeek();
+ if(reviewCount[_student] >4){
+ revert HH__StudentReviewCountExceeded();
+ };
+ if(block.timestamp < lastReviewTime[_student] + reviewTime){
+ revert HH__StudentGivenMoreThanOneReviewPerWeek();
+ };
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.