Submission Details
Severity:
The protocol pays each teacher 35% of the bursary instead of sharing the percentage across all teachers
Summary
The protocol pays each teacher 35% of the bursary instead of sharing the percentage evenly among teachers
Impact
Messes up the accounting of the protocol bursary
Tools Used
Manual Review
Recommendations
Divide the percentage based on the number of teachers in the protocol:
function graduateAndUpgrade(
address _levelTwo,
bytes memory
) public onlyPrincipal {
if (_levelTwo == address(0)) {
revert HH__ZeroAddress();
}
uint256 totalTeachers = listOfTeachers.length;
+ require(totalTeachers > 0, "There are no teachers in the system");
+ uint256 teacherCut = (bursary * TEACHER_WAGE) / PRECISION;
+ uint256 payPerTeacher = teacherCut / totalTeachers;
+ uint256 principalPay = (bursary * PRINCIPAL_WAGE) / PRECISION;
_authorizeUpgrade(_levelTwo);
for (uint256 n = 0; n < totalTeachers; n++) {
+ usdc.safeTransfer(listOfTeachers[n], payPerTeacher);
}
usdc.safeTransfer(principal, principalPay);
}
Updates
Lead Judging Commences
yeahchibyke 6 months ago
Submission Judgement Published Assigned finding tags:
incorrect teacher pay calculation
`payPerTeacher` in `graduateAndUpgrade()` is incorrectly calculated.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.