Hawk High

First Flight #39
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: high
Valid

Missing Graduation Logic for Eligible Students

Summary

The contract defines a cutOffScore variable and allows score manipulation via review and re-review processes. However, the contract lacks an implementation to automatically identify and graduate students who meet or exceed the cutOffScore.

Despite the presence of a Graduated(address levelTwo) event, the contract only allows manual graduation via _graduate(), which is never called in the context of students reaching the required score. This creates a logical gap where eligible students remain stuck in the student list even though they’ve met graduation criteria.

Vulnerability Details

No logic exists to evaluate or upgrade students based on their score.

Impact

eligible students remain stuck in the student list even though they’ve met graduation criteria.

Tools Used
manual review

Recommendations

Introduce a new public function graduateStudents(address _levelTwo) callable by the principal that:

  • Iterates through listOfStudents.

  • Checks studentScore >= cutOffScore.

Updates

Lead Judging Commences

yeahchibyke Lead Judge 6 months ago
Submission Judgement Published
Validated
Assigned finding tags:

cut-off criteria not applied

All students are graduated when the graduation function is called as the cut-off criteria is not applied.

yeahchibyke Lead Judge 6 months ago
Submission Judgement Published
Validated
Assigned finding tags:

cut-off criteria not applied

All students are graduated when the graduation function is called as the cut-off criteria is not applied.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.