Hawk High

First Flight #39
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: high
Valid

Lack of cutOffScore Enforcement in graduateAndUpgrade Function

Summary The function does not filter out students who fail to meet the cutOffScore. That is against the the repo's doc.

Impact Students who do not meet the required score may incorrectly graduate, violating the contract's intended functionality. this maks the function giveReview have zero meaning

Tools Used manual review

Recommendations Add logic to exclude students with scores below the cutOffScore from the upgrade process.

Updates

Lead Judging Commences

yeahchibyke Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

cut-off criteria not applied

All students are graduated when the graduation function is called as the cut-off criteria is not applied.

yeahchibyke Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

cut-off criteria not applied

All students are graduated when the graduation function is called as the cut-off criteria is not applied.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.