Submission Details
Severity:
Incorrect Salary Distribution Logic in graduateAndUpgrade
Summary The current logic allocates 35% of the bursary to each teacher instead of distributing 35% collectively among all teachers.
Vulnerability Details in LevelOne.sol file
uint256 payPerTeacher = (bursary * TEACHER_WAGE) / PRECISION;
the code shows that payPerTeacher = ( bursary * 35 ) /100, but that is only correct when there's one teacher.
Impact Teacher won't get pay correctly. Tf there's three teacher. it even results in overpayment, exceeding the total bursary. (105% payment to the teachers)
Tools Used manul review
Recommendations Adjust the logic to divide 35% of the bursary equally among all teachers :
uint256 payPerTeacher = (bursary * TEACHER_WAGE) / (PRECISION*totalTeachers);
Updates
Lead Judging Commences
yeahchibyke 3 months ago
Submission Judgement Published Assigned finding tags:
incorrect teacher pay calculation
`payPerTeacher` in `graduateAndUpgrade()` is incorrectly calculated.
yeahchibyke 3 months ago
Submission Judgement Published Assigned finding tags:
incorrect teacher pay calculation
`payPerTeacher` in `graduateAndUpgrade()` is incorrectly calculated.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.