Submission Details
Impact:
Likelihood:
Inefficient Iteration in expel and removeTeacher Functions
Summary These functions iterate over the entire list to remove an entry.
Vulnerability Details
for (uint256 n = 0; n < teacherLength; n++) {
if (listOfTeachers[n] == _teacher) {
listOfTeachers[n] = listOfTeachers[teacherLength - 1];
listOfTeachers.pop();
break;
}
}
Impact High gas costs and potential reverts for large lists.
Tools Used github copilot
Recommendations Use a mapping for efficient lookups and removals, or maintain an index mapping to reduce iteration costs.
Rewards breakdown
nSLOC
243This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.