Snowman Merkle Airdrop
First Flight #42
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Impact: high
Likelihood: high
Invalid

### [H-3] No s_buyFee Changing Mechasnism in ```Snow``` Contract.

wolf_kalp

[H-3] No s_buyFee Changing Mechasnism in Snow Contract.

Description

The Snow contract does not have s_buyFee Changing Mechasnism.
The s_buyFee is charged in terms of ETH and WETH for users ,leading to issues such as
change in price of ETH and WETH ,as eth and weth are extremely volatile currencies.

Impact:

1.If the value of ETH and WETH increases too much ,which makes users discouragement of participation in
protcol

2.Vicevera,if price decreases too much then protcol sustainibility gets shaken.

Proof of Concept

1.Initial Scenario:
​
->Suppose the price of 1 ETH is 2000 USD.
​
->User Alice wants to buy one Snow token by paying One ETH.
​
Result:Alice Got one Snow Token for 2000$.
​
2.Scenario After Price Fluctuation:
​
->Now The ETH price is decreased to 600$.
​
->User Bob wants to buy one Snow token by paying One ETH.
​
Result:Bob got one same snow token only for 600$.
​
Final Result:
​
1.Unfairness Among Users
​
2.Economic Imbalance
​
3.Static Fee Inflexibility
​
​

Recommended Mitigation

1.To avoid the price fluctuation issue of ETH and WETH

2.Add Function to updatebuyfee via OnlyOwner.

3.Now owner can change s_buyfee according to price of ETH and WETH

function updateBuyFee(uint256 newFee) external onlyOwner {
if (newFee == 0) {
revert("Buy fee cannot be zero");
}
s_buyFee = newFee;
​
emit BuyFeeUpdated(newFee);
}
Updates

Lead Judging Commences

yeahchibyke Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.