[L-3] Snow::collectFee() does not emit the FeeCollected() event and event listeners will never know when fee is collected

Description

• The collectFee() function allows user to collect the fees accumulated. However, no events are emitted when the function is called.

Risk

Likelihood:

• Whenever the collectFee() event is called to collect the fee from protocol

Impact:

• Frontends depending on event emission to detect when fee is collected will never be able to update because no events are emitted

Proof of Concept

The FeeCollected event is defined in the contract like the following:

However, it has never been used in the contract.

Recommended Mitigation:

Modify the collectFee() function to be like the following so that, every time fee is collected using this function, an event will be emitted and thus, any frontend that depend on an event emission will be able to update properly. It has been put on top of the transfer calls to prevent reentrancy attacks.