Submission Details
Impact:
Likelihood:
[GAS] Public function which is unused inside code can be made external to save gas fees
[GAS] Snowman::tokenUri() is never called inside the contract even though it is a public function and consumes more gas
Description
Snowman::tokenUri()is a public function which allows it to be called from within the contract too. But since it has never been used in the contract, it should be madeexternalto save gas fees
// >>> PUBLIC FUNCTIONS
@> function tokenURI(uint256 tokenId) public view virtual override returns (string memory) {
if (ownerOf(tokenId) == address(0)) {
revert ERC721Metadata__URI_QueryFor_NonExistentToken();
}
Risk
Likelihood:
Whenever
tokenUri()is called
Impact:
Slightly higher gas fees
Recommended Mitigation
// >>> PUBLIC FUNCTIONS
- function tokenURI(uint256 tokenId) public view virtual override returns (string memory) {
+ function tokenURI(uint256 tokenId) external view virtual override returns (string memory) {
if (ownerOf(tokenId) == address(0)) {
revert ERC721Metadata__URI_QueryFor_NonExistentToken();
}
Rewards breakdown
nSLOC
215This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.