Snowman Merkle Airdrop
First Flight #42
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Impact: low
Likelihood: low
Invalid

Unchecked Return Value in collectFee() May Lead to Silent Fee Transfer Failures

ayb

[L-1] Unchecked Return Value in collectFee() May Lead to Silent Fee Transfer Failures

Description: The Snow::collectFee() function calls i_weth.transfer() to send collected WETH to the collector. However, it does not check the return value of the transfer() call. While this isn't dangerous in the current context (where the protocol controls the WETH contract), failing to check return values violates best practices and could silently fail in future upgrades or token changes.

Impact:

  • If transfer() fails silently, fees will not be collected, but the protocol will behave as if they were.

  • Creates confusion or inconsistencies during audits or operations.

  • May break invariants if token contracts are updated or swapped in the future.

Proof of Concept:

i_weth.transfer(s_collector, collection); // no check!

Recommended Mitigation:

- i_weth.transfer(s_collector, collection);
+ require(i_weth.transfer(s_collector, collection), "Transfer failed");
Updates

Lead Judging Commences

yeahchibyke Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.