Root + Impact

Root: The collectFee function transfers collected fees to the collector but fails to emit the declared FeeCollected event, despite the event being properly defined in the contract.

Impact: Fee collection activities cannot be properly tracked or monitored off-chain, reducing transparency and making it difficult to audit fee collection history or verify collector behavior.

Description

• Normal Behavior: Fee collection functions should emit events to provide transparency and enable off-chain monitoring of when fees are collected and by whom.

• Specific Issue: The FeeCollected event is declared but never emitted in the collectFee() function, creating a gap in the contract's event logging and preventing proper tracking of fee collection activities.

Risk

Likelihood: High

• Every call to collectFee() triggers this issue as the event is never emitted

• Fee collection is a regular operational activity that will occur frequently throughout the protocol's lifecycle

Impact: Low

• Poor Transparency: Off-chain monitoring systems cannot track fee collection activities automatically

• Audit Difficulties: Historical fee collection data cannot be easily retrieved from blockchain events, complicating financial audits

Recommended Mitigation

Add the missing event emission to the collectFee() function to enable proper tracking and transparency of fee collection activities.