Submission Details
Impact:
Likelihood:
[L-6] mintSnowman does not check for 0 amount
[L-6] Snowman::mintSnowman does not check for 0 amount
Description
-
The
mintSnowman()takes in parameteramountfor determining the number of NFTs to mint -
The function does not check for 0 amount which basically does nothing
function mintSnowman(address receiver, uint256 amount) external {
for (uint256 i = 0; i < amount; i++) {
_safeMint(receiver, s_TokenCounter);
emit SnowmanMinted(receiver, s_TokenCounter);
s_TokenCounter++;
}
}
Risk
Likelihood:
Whenever
mintSnowman()is called withamount= 0
Impact:
Unnecessary function execution
Proof of Concept
Add the following test case to the test suite of Snowman
function test_zeroAmount() public {
nft.mintSnowman(alice, 0);
}
Recommended Mitigation
+ assert(amount != 0);
Rewards breakdown
nSLOC
215This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.