Snowman Merkle Airdrop

First Flight #42
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Impact: medium
Likelihood: medium
Invalid

[M-1] Missing Amount Parameter in FeeCollected Event

Root + Impact

  • Root: The FeeCollected event is emitted without an amount parameter, limiting tracking capability;

  • Impact: Obscures the exact fee value collected, hindering auditability and transparency.

Description

  • The FeeCollected event is intended to log when fees are collected, but it lacks a parameter to specify the amount, reducing its utility for monitoring transactions.

  • This omission makes it difficult to verify or trace the exact fees processed, potentially leading to oversight in financial tracking.

// Root cause in the codebase with @> marks to highlight the relevant section
@> event FeeCollected();

Risk

Likelihood:

  • During every fee collection transaction that emits this event.

  • When auditing or reconciling collected fees.

Impact:

  • Reduces transparency, complicating fee verification.

  • Increases risk of undetected discrepancies in financial records.

Recommended Mitigation

- event FeeCollected();
+ event FeeCollected(uint256 amount);

Add a uint256 amount parameter to the FeeCollected event to record the collected fee value.

Updates

Lead Judging Commences

yeahchibyke Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.