Submission Details
Impact:
Likelihood:
`Snow::changeCollector` function `missing check for duplicate collectors.
Description:
The Snow::changeCollector function have check for zero address, but not for set the active collector again.
function changeCollector(address _newCollector) external onlyCollector {
if (_newCollector == address(0)) {
revert S__ZeroAddress();
}
@> s_collector = _newCollector;
emit NewCollector(_newCollector);
}
Impact:
Unnecesary gas consumption
Recommended Mitigation:
On Snow::changeCollector revert if the new collector address is the same that the old:
function changeCollector(address _newCollector) external onlyCollector {
if (_newCollector == address(0)) {
revert S__ZeroAddress();
}
+ if (s_collector == _newCollector) {
+ revert("Not Allow The Same Address");
+ }
s_collector = _newCollector;
emit NewCollector(_newCollector);
}
Rewards breakdown
nSLOC
215This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.