Submission Details
Severity:
Off-by-One Error in Memorabilia Minting Supply Check
Root
The function is designed to allow users to redeem memorabilia NFTs from a collection, up to a specified maxSupply. The current check uses
Impact:
**Off-by-One Error: **The current logic only allows minting up to maxSupply - 1 NFTs. The last possible itemId that can be minted is maxSupply - 1.
Proof of Concept
Recommended Mitigation
Change the check to use <= (less than or equal):
- require(collection.currentItemId < collection.maxSupply, "Collection sold out");
+ require(collection.currentItemId <= collection.maxSupply, "Collection sold out");
Updates
Lead Judging Commences
inallhonesty
about 1 month ago
inallhonesty about 1 month ago
Submission Judgement Published Assigned finding tags:
Off by one error in redeemMemorabilia
Rewards breakdown
nSLOC
234This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.