Beatland Festival
First Flight #44
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Impact: low
Likelihood: low
Invalid

Missing event emission in `FestivalPass.setOrganizer`.

mustby

Missing event emission in FestivalPass.setOrganizer.

Description: Lack of event emission upon the owner updating the organizer reduces transparency between the protocol and its users. It is important for users to be able to know and understand who the organizer is.

function setOrganizer(address _organizer) public onlyOwner {
organizer = _organizer;
}

Impact:

Likelihood: LOW

  • The FestivalPass.setOrganizer function is likely not going to be called often.

Impact: VERY LOW

  • Lack of event emission makes it difficult to track off-chain organizer changes.


Proof of Concept:

N/A


Recommended Mitigation: Add the event emission line to FestivalPass.setOrganizer:

function setOrganizer(address _organizer) public onlyOwner {
organizer = _organizer;
+ emit OrganizerSet(address indexed organizer);
}

Also, add the event itself to IFestivalPass.sol.

+ /**
+ * @notice Emitted when the organizer address is created or updated
+ * @param organizer the updated organizer address set by the owner
+ */
+ event OrganizerSet(address indexed organizer);
Updates

Lead Judging Commences

inallhonesty Lead Judge 26 days ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Missing events / Events not properly configured

Informational. This protocol doesn't rely on events to function, they are just nice to have, but not mandatory.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.