Beatland Festival

First Flight #44
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Impact: low
Likelihood: low
Invalid

Low Findings

1. Redundant tokenIdToEdition Mapping

Description: tokenIdToEdition duplicates decodeTokenId() data.
Impact: Wasted gas, storage bloat.
Recommendation: Remove mapping and use decodeTokenId() instead.

2. Hardcoded Pass URI

Description: Cannot update pass metadata post-deployment.
Recommendation:

string private _basePassURI;
function setBasePassURI(string memory uri) external onlyOwner {
_basePassURI = uri;
}

3. Missing Withdraw Event

Description: No event emitted on ETH withdrawals.
Impact: Poor auditability.
Recommendation:

event FundsWithdrawn(address indexed receiver, uint256 amount);
function withdraw(address target) external onlyOwner {
uint256 amount = address(this).balance;
payable(target).transfer(amount);
emit FundsWithdrawn(target, amount);
}
Updates

Lead Judging Commences

inallhonesty Lead Judge about 2 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Missing events / Events not properly configured

Informational. This protocol doesn't rely on events to function, they are just nice to have, but not mandatory.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.