Beatland Festival

First Flight #44
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Impact: low
Likelihood: high
Invalid

Misleading Parameter Name in `FestivalPass:buyPass` causing misuse/misinterpretation

Misleading Parameter Name in FestivalPass:buyPass causing misuse/misinterpretation.

Description

The parameter collectionId in FestivalPass::buyPass() is used to represent passId, however it is named collectionId instead of passId.
The collectionId refers to a unique identifier to a collection while passId refers to pass type that the user want to buy.

@> function buyPass(uint256 collectionId) external payable;

Risk

Likelihood:

High

Impact:

  • Reduces code clarity and increases the chance of misuse or misinterpretation.

  • Inaccurate naming can mislead future developers or reviewers about the function’s actual behavior and input expectations.

Proof of Concept

N/A

Recommended Mitigation

Rename collectionId to passId to better reflect its purpose.

Updates

Lead Judging Commences

inallhonesty Lead Judge 26 days ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.