Submission Details
Severity:
Redundant Defensive Check for Platform Fee
Unnecessary check for platform fee in claimThrone method, reduces clarity
Description
-
The contract checks if the platform fee exceeds the available amount after previous king payout, but
platformFeePercentageis already validated to be ≤ 100 andpreviousKingPayoutis always zero. -
This check is unnecessary and adds confusion.
// src/Game.sol
@>if (currentPlatformFee > (sentAmount - previousKingPayout)) { //@> Redundant check
currentPlatformFee = sentAmount - previousKingPayout;
}
Risk
Likelihood:
-
This occurs every time
claimThrone()is called. -
The check never triggers due to input validation.
Impact:
No functional impact, but reduces code clarity and maintainability.
Proof of Concept
// platformFeePercentage is always ≤ 100, so currentPlatformFee never exceeds sentAmount
Recommended Mitigation
Remove the redundant check.
- @>if (currentPlatformFee > (sentAmount - previousKingPayout)) { //@> Redundant check
- currentPlatformFee = sentAmount - previousKingPayout;
- }
Updates
Appeal created
inallhonesty about 1 month ago
Submission Judgement Published Assigned finding tags:
Missing Previous King Payout Functionality
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.