Centralization Risk, Owner Can set the Fees how much he wants.

Description

• Owner can set the Fees given to him or the platform as much as he wants to!!!

• The Owner has too much Control of the Contract thus risking Decentralization.

• The below code is just a one instance of it, there is another of it in the Reset Function.

  function updateClaimFeeParameters(

  uint256 _newInitialClaimFee,

  uint256 _newFeeIncreasePercentage

  ) external onlyOwner isValidPercentage(_newFeeIncreasePercentage) {

  require(_newInitialClaimFee > 0, "...");

  initialClaimFee = _newInitialClaimFee;

  feeIncreasePercentage = _newFeeIncreasePercentage;

  emit ClaimFeeParametersUpdated(_newInitialClaimFee, _newFeeIncreasePercentage);

  }

Risk: Medium

We don't know if the Owner is an Angel,we can trust him or not we dont really know so its -Medium-.

Likelihood:

• This will occur when the Owner will decide to increase the Fees to literally how much he wants to!

Impact:

• Too Much Control in Owner can cause the Trust in people to fail.

• People don't get the Amount as the Owner can get how much he wants to risking Decentralization.

• And if he sets the fees too high then the Game would be unplayable and no one will want to play it.

Proof of Concept:

1. Owner sets the platform fee to 100%

1. David tries to claim the throne with 1 ETH

All of David's 1 ETH goes to platformFeesBalance (owner), nothing to pot.

3. Owner sets initialClaimFee to 100 ether or watever he wants.

4. No one can afford to play anymore. Game is locked.

Recommended Mitigation

There isnt an exact Mitigation i can give as the Code will be Big, But u can set the Fee amount changed by Owner cannot exceed a threshold in Constant State Variables.

And Create a Modifier that Restricts the Owner.

In Total u want to Restrict the Owner so that he/she can't just change the Fees to 100%.

In Summary people will be not be so happy even if the Owner doesn't do anything silly.