Last Man Standing

First Flight #45
Beginner FriendlyFoundrySolidity
100 EXP
View results
Submission Details
Impact: low
Likelihood: low
Invalid

[L-2] `nonReentrant` should be the first modifier at `Game::withdrawPlatformFees`.

Root + Impact

[L-2] nonReentrant should be the first modifier at Game::withdrawPlatformFees.

Description

To protect against reentrancy in other modifiers, the nonReentrant modifier should be the first modifier in the list of modifiers.

Risk

Likelihood: Low

Impact: Low

Proof of Concept

The Game::withdrawPlatformFees function is defined as follows:

function withdrawPlatformFees() external onlyOwner nonReentrant {

Recommended Mitigation

Place the nonReentrant modifier as the first modifier in the list of modifiers of the Game::withdrawPlatformFees function.

- function withdrawPlatformFees() external onlyOwner nonReentrant {
+ function withdrawPlatformFees() external nonReentrant onlyOwner {
Updates

Appeal created

inallhonesty Lead Judge about 1 month ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.