Root + Impact

Description

• The owner is meant to adjust game parameters only between rounds, ensuring that ongoing rounds are not unfairly influenced.

• In the current code, the owner can change parameters (such as gracePeriod, initialClaimFee, etc.) at any time, including during active rounds. This undermines fairness and can lead to manipulative game outcomes.

Risk

Likelihood:

• This occurs anytime the owner chooses to change parameters during a live round.

• There are no guards preventing mid-game manipulation.

Impact:

• The owner can end the game early (e.g., by shortening the grace period).

• Players may lose trust in the fairness and transparency of the game.

Proof of Concept

Explanation:
No check ensures that updates only happen when the game is ended. The owner can change critical game dynamics during a round, potentially for personal gain or to alter outcomes.

Recommended Mitigation

Mitigation Explanation:
By applying the gameEndedOnly modifier to parameter update functions, changes are allowed only between rounds, preserving fairness and preventing manipulation.