Submission Details
Severity:
No one is able to participate in the game
Root + Impact
Description
Function Game::claimThrone has an incorrect validation that does not allow anyone to participate in the game.
Risk
Likelihood: High
The function does not allow anyone to participate
Impact: High
The contract does not work
Proof of Concept
Function claimThrone has the validation below:
require(msg.sender == currentKing, "Game: You are already the king. No need to re-claim.");
This validation only allows the current king to call the function. Since currentKing is 0 after the contract initialization, the function will always revert since msg.sender cannot be 0.
Recommended Mitigation
Fix the validation:
-require(msg.sender == currentKing, "Game: You are already the king. No need to re-claim.");
+require(msg.sender != currentKing, "Game: You are already the king. No need to re-claim.");
Updates
Appeal created
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
Game::claimThrone `msg.sender == currentKing` check is busted
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.