Submission Details
Severity:
Previous king does not receive portion of the new king claimFee
Root + Impact
Description
According to the documentation and to comments in the code, the previous king must receive part of the new king's claim fee. Function claimThrone declares a variable previousKingPayout taht is always 0 and that is never used to send ETH to the previous king.
uint256 sentAmount = msg.value;
uint256 previousKingPayout = 0;
uint256 currentPlatformFee = 0;
uint256 amountToPot = 0;
// Calculate platform fee
currentPlatformFee = (sentAmount * platformFeePercentage) / 100;
// Defensive check to ensure platformFee doesn't exceed available amount after previousKingPayout
if (currentPlatformFee > (sentAmount - previousKingPayout)) {
currentPlatformFee = sentAmount - previousKingPayout; //@audit no payment for previous
}
Risk
Likelihood: High
The previous king never receives ETH
Impact: High
The previous king loses funds
Recommended Mitigation
Add a mapping that will store pending payouts for previous kings so that they can claim their funds.
Updates
Appeal created
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
Missing Previous King Payout Functionality
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.