Submission Details
Severity:
pot Is Reset Before Emitting GameEnded, Causing Logged Value to Always Be 0
pot Is Reset Before Emitting GameEnded, Causing Logged Value to Always Be 0
Description
-
GameEnded event is emitted after declareWinner() is called.And it will log some information(ect. winner,pot).
-
The value of pot in log will always be 0.
function declareWinner() external gameNotEnded {
require(
currentKing != address(0),
"Game: No one has claimed the throne yet."
);
require(
block.timestamp > lastClaimTime + gracePeriod,
"Game: Grace period has not expired yet."
);
gameEnded = true;
pendingWinnings[currentKing] = pendingWinnings[currentKing] + pot;
@> pot = 0; // Reset pot after assigning to winner's pending winnings
emit GameEnded(currentKing, pot, block.timestamp, gameRound);
}
Risk
Likelihood:High
It will happen when GameEnded event is emitted.
Impact:Low
It does not cause any problem but log the value always 0 do not make any sense.
Proof of Concept
GameEnded event emitted after variable pot set to 0.
pot = 0; // Reset pot after assigning to winner's pending winnings
emit GameEnded(currentKing, pot, block.timestamp, gameRound);
Recommended Mitigation
Change the order of reset variable pot and emitted the GameEnded event would solve this problem.
function declareWinner() external gameNotEnded {
require(
currentKing != address(0),
"Game: No one has claimed the throne yet."
);
require(
block.timestamp > lastClaimTime + gracePeriod,
"Game: Grace period has not expired yet."
);
gameEnded = true;
pendingWinnings[currentKing] = pendingWinnings[currentKing] + pot;
- pot = 0; // Reset pot after assigning to winner's pending winnings
emit GameEnded(currentKing, pot, block.timestamp, gameRound);
+ pot = 0; // Reset pot after assigning to winner's pending winnings
}
Updates
Appeal created
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
Game::declareWinner emits GameEnded event with pot = 0 always
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.