Submission Details
Impact:
Likelihood:
Unnecessary Double Transfer in `buyOrder()` (Gas Optimization)
The current implementation transfers protocolFee and sellerReceives separately, which costs more gas:
iUSDC.safeTransferFrom(msg.sender, address(this), protocolFee);
iUSDC.safeTransferFrom(msg.sender, order.seller, sellerReceives);
Optimization:
A single safeTransferFrom for the full amount followed by an internal transfer to the protocol would save gas:
iUSDC.safeTransferFrom(msg.sender, address(this), order.priceInUSDC);
iUSDC.safeTransfer(order.seller, sellerReceives);
Scope:
https://github.com/CodeHawks-Contests/2025-07-orderbook/blob/main/src/OrderBook.sol
../src/OrderBook.sol
I was unable to select scope in scope section !
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.