OrderBook

Description

The contract emits events like OrderCreated to record key state changes. However, these events do not index critical parameters such as orderId and seller, making it difficult for off-chain systems to efficiently filter and process data.

Root + Impact

Normal Behavior:
Events provide a historical log that off-chain indexers (like TheGraph, Dune Analytics, custom bots) use to track protocol state and user-specific actions.

Issue:
Without indexed keywords on key parameters, these systems must scan and decode every single log to find relevant events. This drastically increases indexing time and computational costs.

Example scenario:
A wallet trying to display all orders for seller must fetch all OrderCreated logs from block 0, decode them, then check seller manually. This results in slower UIs, higher RPC costs, and potential missed orders due to timeouts.

Risk

Likelihood

• Always occurs — every off-chain tool reading order data faces this inefficiency.

Impact

• Low — does not affect funds, but negatively impacts user experience, dApp performance, and long-term ecosystem costs.

Proof of Concept

A typical TheGraph subgraph handler for unindexed events has to process every event:

This increases sync time and may cause delayed user balances or dashboards.

Recommended Mitigation

By indexing orderId and seller, off-chain systems can use native eth_getLogs filtering to instantly find relevant events, reducing RPC load and improving dashboard responsiveness. This makes the protocol more scalable and cheaper for integrators.