Submission Details
Impact:
Likelihood:
withdraw fees doesn't follow CEI pattern.
Root + Impact CEI pattern is not followed
Description
-
withDrawFees()function doesn't follow cei patter -
Vulnerable to reentrancy
// Root cause in the codebase with @> marks to highlight the relevant section
function withdrawFees(address _to) external onlyOwner {
if (totalFees == 0) {
revert InvalidAmount();
}
if (_to == address(0)) {
revert InvalidAddress();
}
iUSDC.safeTransfer(_to, totalFees);
@> totalFees = 0;
emit FeesWithdrawn(_to);
}
Risk
Likelihood:
-
onlyOwnermakes exploitation unlikely, but not impossible (if ownership is compromised).
Impact:
-
If
iUSDCwere a malicious ERC20 token with a hook intransfer, it could reenter the contract. -
Impact 2
Proof of Concept
Recommended Mitigation
- iUSDC.safeTransfer(_to, totalFees);
+ totalFees = 0;
+ iUSDC.safeTransfer(_to, totalFees);
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.