OrderBook
First Flight #43
Beginner FriendlySolidity
100 EXP
View results
Previous Next
Submission Details
Impact: low
Likelihood: medium
Invalid

The `_owner` shadows the state variable on `Ownable` contract.

biks81

Low

[L-1] The _owner shadows the state variable on Ownable contract.

Description : The constructor in OrderBook contract takes an argument of _owner and assigns that _owner to Ownable constructor. However, the Ownable contract uses _ownable address as a state variable. This affects the code readiability and clarity for those who reads code casually.

Recommended Mitigation :

- constructor(address _weth, address _wbtc, address _wsol, address _usdc, address _owner) Ownable(_owner) { }
​
+ constructor(address _weth, address _wbtc, address _wsol, address _usdc, address _initialOwner) Ownable (_initialOwner) { }
Updates

Lead Judging Commences

yeahchibyke Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.