Submission Details
Impact:
Likelihood:
Unnecessary Use of Strings Utility Library, Increases Bytecode of the Contract
# Unnecessary Use of Strings Utility Library, Increases Bytecode of the Contract
## Description
The `Strings` utility is imported and used solely for the `getOrderDetailsString()` function, which is an off-chain utility. Including the entire `Strings` library increases bytecode size and gas usage during deployment, unnecessarily.
```solidity
import {Strings} from "@openzeppelin/contracts/utils/Strings.sol";
```
## Risk
**Likelihood:**
* Always present at compile/deployment time
**Impact:**
* Increased bytecode size
* Higher deployment cost
## Proof of Concept
Remove `getOrderDetailsString()` and the `Strings` import — observe reduced bytecode size.
## Recommended Mitigation
Consider moving the logic off-chain (via The Graph or frontend rendering), or keep it in a separate view-only helper contract.
```diff
- import {Strings} from "@openzeppelin/contracts/utils/Strings.sol";
```
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.