Submission Details
Impact:
Likelihood:
Extra time order
Description
-
The user can amend his order to add extra time anytime he wants
-
There is no real restriction on the duration of the order's validity.
Risk
Likelihood:
When a user amend his order
Impact:
An order can be active as long as the user wants
Proof of Concept
function test_extraTimeOrder() public {
// clara creates sell order for wsol
vm.startPrank(clara);
wsol.approve(address(book), 2e18);
uint256 claraId = book.createSellOrder(
address(wsol),
2e18,
300e6,
2.5 days
);
vm.stopPrank();
vm.warp(block.timestamp + 2 days);
// clara amends her wsol order
vm.prank(clara);
book.amendSellOrder(claraId, 2e18, 300e6, 2.5 days);
vm.warp(block.timestamp + 2 days);
vm.prank(clara);
book.amendSellOrder(claraId, 2e18, 300e6, 2.5 days);
vm.warp(block.timestamp + 2 days);
vm.prank(clara);
book.amendSellOrder(claraId, 2e18, 300e6, 2.5 days);
assert(book.getOrder(claraId).isActive == true);
}
Recommended Mitigation
Take into consideration the deadline set at the order creation
Updates
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.