Submission Details
Impact:
Likelihood:
Duplicate code in 'OrderBook::getOrderDetailsString' function
[L-1] OrderBook::getOrderDetailsString function contains redundant logic used to determine the order status, which results in excessive gas usage
Description:
OrderBook::getOrderDetailsString function contains duplicate logic used determine the order status:
Block 1:
string memory status = order.isActive
? (block.timestamp < order.deadlineTimestamp ? "Active" : "Expired (Active but past deadline)")
: "Inactive (Filled/Cancelled)";
Block 2:
if (order.isActive && block.timestamp >= order.deadlineTimestamp) {
status = 'Expired (Awaiting Cancellation)';
} else if (!order.isActive) {
status = 'Inactive (Filled/Cancelled)';
} else {
status = 'Active';
}
These two blocks of code are equivalent except for the inactive status string ("Expired (Active but past deadline)" in block 1 vs "Expired (Awaiting Cancellation)" in block 2).
"Expired (Awaiting Cancellation)" in block 2 makes more sense in the context of protocol logic. In addition, block 2 is more readable.
Impact:
Duplicate code causes excessive gas consumption.
Recommended Mitigation:
Remove duplicate code (block 1).
- string memory status = order.isActive
+ string memory status;
- ? (block.timestamp < order.deadlineTimestamp ? "Active" : "Expired (Active but past deadline)")
- : "Inactive (Filled/Cancelled)";
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.