Root + Impact

Description

• Normal behavior: The contract owner can add or remove tokens from the allowedSellToken mapping, enabling or disabling them for order creation.
  Issue: The owner can add any ERC20 token (except USDC) to the allowed list, including tokens with malicious or non-standard behavior (e.g., fee-on-transfer, reentrancy, or tokens that revert on transfer).

• Issue:

The function allows the owner to add any ERC20 token (except USDC or the zero address) to the allowed list. This means tokens with non-standard or malicious behavior (such as fee-on-transfer, reentrancy, or tokens that revert on transfer) can be added. If such a token is allowed, users may unknowingly create orders with it, leading to unexpected results, loss of funds, or even contract vulnerabilities.

Risk

Likelihood:

• The owner may inadvertently or maliciously add a non-standard or malicious token.

• Users may create orders with such tokens, leading to unexpected behavior or loss of funds.

Impact:

• Users may lose funds if tokens behave unexpectedly (e.g., fee-on-transfer, reentrancy).

• The contract may become unusable or funds may be locked.

Proof of Concept

Recommended Mitigation