Submission Details
Impact:
Likelihood:
### [M-1] Centralization Risk::Malicious Onwer can Disable Core tokens.
[M-1] Centralization Risk::Malicious Onwer can Disable Core tokens.
Description
The OrderBook::setAllowedSellToken allows OnlyOnwer to enable and disable specific tokens.
However,This is considered as centralization risk,if owner become compromised or maliciousthey could
set setAllowedSellToken[false] for core tokens such as weth,wbtc,wsol.Which leads to entire
protocol disruption.Sellers can no longer create sell orders of core tokens.
Impact:
1.Denial of service for all sellers of disabled tokens.
2.Protocol disruption and loss of user trust.
3.Sellers tokens gets locked permanently.
Proof of Concept
Owner Disabling weth token:
function test_centralisationrisk() public {
address wethtoken = address(orderbook.iWETH());
vm.startPrank(owner);
orderbook.setAllowedSellToken(wethtoken, false);
vm.stopPrank();
vm.startPrank(bobseller);
weth.approve(address(orderbook), type(uint).max);
vm.expectRevert(OrderBook.InvalidToken.selector);
uint orderid = orderbook.createSellOrder(
address(weth),
2e18,
2000e6,
1 days
);
vm.stopPrank();
}
Recommended Mitigation
Disallow disabling core tokens
function setAllowedSellToken(
address _token,
bool _isAllowed
) external onlyOwner {
+if(!_isAllowed && _token ==address(IWETH) || (_token==address(IWETH)) || (_token==address(IWETH) ) ){
+ revert InvalidToken();
+ }
if (_token == address(0) || _token == address(iUSDC))
revert InvalidToken(); // Cannot allow null or USDC itself
allowedSellToken[_token] = _isAllowed;
emit TokenAllowed(_token, _isAllowed);
}
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.