Submission Details
Impact:
Likelihood:
### [L-1] Incorrect Deadline Check in `buyOrder`
[L-1] Incorrect Deadline Check in buyOrder
Description
It was intially assumed that the deadline check in buyOrder function should use >=:
if (block.timestamp >= order.deadlineTimestamp) revert OrderExpired();
However ,this is an incorrect behaviour .An order with block.timestamp==deadline should
still be valid and buyable at the exact moment.Using >= prematurely restrict buyers to buy
at exact moment.
Impact:
1.Buyers failes to buy order at precise deadline.
2.Could discourage last-moment trades.
Proof of Concept
1.Seller creates an order with deadlineTimestamp = 3:00 PM.
2.Buyer sends a transaction at exactly 3:00 PM (block.timestamp == deadlineTimestamp).
3.If >= is used, the transaction reverts — though the order should still be valid.
Recommended Mitigation
Use Only >,Which will allow buyers to buy at exact moment and reverting after that.
function buyOrder(uint256 _orderId) public {
Order storage order = orders[_orderId];
// Validation checks
if (order.seller == address(0)) revert OrderNotFound();
if (!order.isActive) revert OrderNotActive();
-if(block.timestamp >= order.deadlineTimestamp) revert OrderExpired();
+if(block.timestamp > order.deadlineTimestamp) revert OrderExpired();
order.isActive = false;
}
Rewards breakdown
nSLOC
217This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.