Secret Vault on Aptos
First Flight #46
Beginner FriendlyWallet
100 EXP
View results
Previous Next
Submission Details
Impact: high
Likelihood: high
Invalid

`set_secret` Lacks an Ownership Check

martinyordanov2

Description

  • The design of the module suggests that only the owner can set/access secrets.

  • The set_secret function doesn't have an ownership check, therefore any user can set a secret.

// Root cause
public entry fun set_secret(caller:&signer,secret:vector<u8>){
let secret_vault = Vault{secret: string::utf8(secret)};
move_to(caller,secret_vault);
event::emit(SetNewSecret {});
}

Risk

Likelihood:

  • All accounts that can call the function can write secrets to their own vault.

Impact:

  • Unauthorized users can bypass the owner-only policy and create secret vaults

Proof of Concept

#[test(owner = @0xcc, user = @0x123)]
fun user_tries_to_set_secret(owner: &signer, user: &signer){
use aptos_framework::account;
account::create_account_for_test(signer::address_of(user));
let secret = b"i'm a secret";
set_secret(user,secret);
}

Recommended Mitigation

Add an ownership check so only the owner can set secrets

public entry fun set_secret(caller:&signer,secret:vector<u8>){
+ assert!(signer::address_of(caller) == @owner, NOT_OWNER);
let secret_vault = Vault{secret: string::utf8(secret)};
move_to(caller,secret_vault);
event::emit(SetNewSecret {});
}
Updates

Lead Judging Commences

bube Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:

Anyone can call `set_secret` function

In Move for Aptos, the term "owner" refers to a signer, which is a verified account that owns a given resource, has permission to add resources and the ability to grant access or modify digital assets. Following this logic in this contest, the owner is the account that owns `Vault`. This means that anyone has right to call `set_secret` and then to own the `Vault` and to retrieve the secret from the `Vault` in `get_secret` function. Therefore, this group is invalid, because the expected behavior is anyone to call the `set_secret` function.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!