Submission Details
Severity:
Will abort if Vault already exists for caller, consider a replace pattern
Will abort if Vault already exists for caller, consider a replace pattern
Description
In
set_secret functionif vault exists for the caller, the function will abort without any custom message or error or event.
public entry fun set_secret(caller:&signer,secret:vector<u8>){
let secret_vault = Vault{secret: string::utf8(secret)};
@> move_to(caller,secret_vault);
event::emit(SetNewSecret {});
}
Risk
Likelihood: medium
Any user trying to create the vault and if vault already exists, the
set_secret functionwill abort without any custom message or error or event emission
Impact: medium
Recommended Mitigation
Add custom error message or event emission for the
set_secret functionindicating the vault already exists.
Updates
Lead Judging Commences
bube 18 days ago
Submission Judgement Published Assigned finding tags:
The `secret` can not be updated
Rewards breakdown
nSLOC
30This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.