Submission Details
Impact:
Likelihood:
Redundant Double Check in has_claimed_slice Function
Root + Impact
Description
-
In the
has_claimed_sliceview function, the implementation performs a redundant double check usingtable::contains. -
The first
if (!table::contains(...)) { return false }already ensures that when the user is not in the table,falseis returned. -
The final
table::contains(&state.claimed_users, user)is therefore redundant, since the value was just checked in the prior condition.
public fun has_claimed_slice(user: address): bool acquires ModuleData, State {
let state = borrow_global<State>(get_resource_address());
if (!table::contains(&state.claimed_users, user)) {
return false
};
table::contains(&state.claimed_users, user)
}
Risk
Likelihood:
No functional bug or security issue.
Impact:
-
Impact 1
-
Impact 2
Proof of Concept
Both branches of logic resolve to the same return value:
If user not in table → return false.
If user in table → return true.
Recommended Mitigation
Remove the redundant check and single-call table::contains directly:
- if (!table::contains(&state.claimed_users, user)) {
- return false
- };
Rewards breakdown
nSLOC
125This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.