Submission Details
Impact:
Likelihood:
Inefficient Resource Address Retrieval in View Function
Description
The get_resource_address() view function recreates the signer from the capability on every call instead of storing the resource address directly in ModuleData. Since the resource account address never changes after initialization, this approach wastes gas unnecessarily.
Root Cause
The function recreates the signer every time to get its address:
fun get_resource_address(): address acquires ModuleData {
let module_data = borrow_global<ModuleData>(@pizza_drop);
let resource_signer = account::create_signer_with_capability(&module_data.signer_cap);
signer::address_of(&resource_signer)
}
Impact
-
Unnecessary gas consumption on every view function call
-
Inefficient pattern that could be avoided with simple storage optimization
Recommended Mitigation
Store the resource address directly in ModuleData during initialization:
struct ModuleData has key {
signer_cap: SignerCapability,
+ resource_address: address,
}
fun init_module(pizza_drop: &signer) {
// ...
+ let resource_address = signer::address_of(&resource_signer);
move_to(pizza_drop, ModuleData {
signer_cap,
+ resource_address,
});
}
#[view]
fun get_resource_address(): address acquires ModuleData {
- let module_data = borrow_global<ModuleData>(@pizza_drop);
- let resource_signer = account::create_signer_with_capability(&module_data.signer_cap);
- signer::address_of(&resource_signer)
+ borrow_global<ModuleData>(@pizza_drop).resource_address
}
Rewards breakdown
nSLOC
125This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.