Bid Beasts
First Flight #49
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Valid

`BidBeastsNFTMarket::placeBid` Function Emits Extra Event

minos

BidBeastsNFTMarket::placeBid Function Emits Extra Event

Description

  • Normally, the placeBid function only handles Buyer making an instant purchase and Buyer placing a bid.

  • However, the code inappropriately emits an AuctionSettled event, which is clearly incorrect.

  • Line 143 in BidBeastsNFTMarketPlace.sol

function placeBid(uint256 tokenId) external payable isListed(tokenId) {
// ... Original code
​
// Line 143
@> emit AuctionSettled(tokenId, msg.sender, listing.seller, msg.value);
​
// ... Original code
}

Risk

Likelihood:

  • Triggered every time a buyer places a bid that does not constitute an instant purchase.
    Impact:

  • Although there is no fund loss, it causes incorrect event interference for the contract's frontend.

Proof of Concept

  • None

Recommended Mitigation

function placeBid(uint256 tokenId) external payable isListed(tokenId) {
// ... Original code
​
// Line 143
- emit AuctionSettled(tokenId, msg.sender, listing.seller, msg.value);
​
// ... Original code
}
Updates

Lead Judging Commences

cryptoghost Lead Judge 2 months ago
Submission Judgement Published
Validated
Assigned finding tags:

BidBeasts Marketplace: Incorrect Event Emission

placeBid emits AuctionSettled even though the auction hasn’t ended, causing misleading event logs.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!