Submission Details
Severity:
Event emitted in the middle of a function
Event emitted in the middle of a function
Description
The function placeBid as an emitted in the middle of the function
function placeBid(uint256 tokenId) external payable isListed(tokenId) {
...
emit AuctionSettled(tokenId, msg.sender, listing.seller, msg.value);
...
}
It will emit a log that informs the Auction is settled even though it could fail the remaining requirements.
Risk
impact (low) : It could emit a wrong log as the bid was not settled, giving wrong information in the blockchain.
likelyhood(Medium) : Could append every time someone failed to bid higher than the previousBid.
Recommended Mitigation
Removing the event is better.
function placeBid(uint256 tokenId) external payable isListed(tokenId) {
...
- emit AuctionSettled(tokenId, msg.sender, listing.seller, msg.value);
...
}
Updates
Lead Judging Commences
cryptoghost 2 months ago
Submission Judgement Published Assigned finding tags:
BidBeasts Marketplace: Incorrect Event Emission
placeBid emits AuctionSettled even though the auction hasn’t ended, causing misleading event logs.
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.