Bid Beasts

First Flight #49
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Misplaced AuctionSettled event in placeBid()

Root + Impact

Description

placeBid emits emit AuctionSettled(tokenId, msg.sender, listing.seller, msg.value); before any settlement - code

AuctionSettled implies finalization — the event is emitted during normal bidding flow which is misleading for indexers and monitoring.

Recommended Mitigation

Remove or move this emit. Emit BidPlaced and AuctionExtended at the appropriate times; only emit AuctionSettled from _executeSale which is done already.

Updates

Lead Judging Commences

cryptoghost Lead Judge 2 months ago
Submission Judgement Published
Validated
Assigned finding tags:

BidBeasts Marketplace: Incorrect Event Emission

placeBid emits AuctionSettled even though the auction hasn’t ended, causing misleading event logs.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!