Bid Beasts

First Flight #49
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Impact: low
Likelihood: medium
Invalid

No Input Validation for _BidBeastsNFT in Constructor

Root + Impact

Description

  • The constructor accepts an _BidBeastsNFT address but does not validate that it is a valid ERC721 contract or non-zero address.

constructor(address _BidBeastsNFT) {
BBERC721 = BidBeasts(_BidBeastsNFT);
}

Risk

Impact:

  • If an invalid or malicious contract address is provided, the marketplace could become unusable or vulnerable to exploits.

Proof of Concept

Not Required.

Recommended Mitigation

Add validation to ensure _BidBeastsNFT is a valid contract .

constructor(address _BidBeastsNFT) {
+require(_BidBeastsNFT!= address(0));
BBERC721 = BidBeasts(_BidBeastsNFT);
}
Updates

Lead Judging Commences

cryptoghost Lead Judge 2 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!