Bid Beasts
First Flight #49
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Valid

Missing Auction Deadline Enforcement

Rising Stars

Description

The documentation for the BidBeastsNFTMarketPlace contract specifies that auctions should have a fixed duration of exactly 3 days. However, the contract code does not implement or enforce this auction deadline. The constants defined in the contract are as follows:

// --- Constants ---
uint256 constant public S_AUCTION_EXTENSION_DURATION = 15 minutes;
uint256 constant public S_MIN_NFT_PRICE = 0.01 ether;
uint256 constant public S_FEE_PERCENTAGE = 5;
uint256 constant public S_MIN_BID_INCREMENT_PERCENTAGE = 5;

There is no constant or logic in the contract to enforce a 3-day auction duration, nor is there any mechanism to automatically close an auction after 3 days. The S_AUCTION_EXTENSION_DURATION constant only specifies a 15-minute extension for auctions (likely for last-minute bids), but it does not address the overall auction duration. This omission allows auctions to potentially remain open indefinitely, which contradicts the documented requirement and could lead to operational issues.

Impact

  • Non-Compliance with Documentation: The contract does not adhere to the specified 3-day auction deadline, leading to a mismatch between the documented behavior and the actual implementation.since the actual implementation allow the auction to be extended infinetly

Recommendation

  • Enforce Deadline for the auctions as mentioned in the documentation

Updates

Lead Judging Commences

cryptoghost Lead Judge 2 months ago
Submission Judgement Published
Validated
Assigned finding tags:

BidBeasts Marketplace: Improper Documentation

Documentation for BidBeasts Marketplace is incomplete or inaccurate, potentially leading to misconfigurations or security misunderstandings.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!