Submission Details
Impact:
Likelihood:
Inconsistent Contract Naming in the `BidBeasts_NFT_ERC721` constructor function
Description
-
Contract names and metadata should be consistent to avoid confusion and maintain professional branding.
-
The contract is named
BidBeastsbut the ERC721 name is set to"Goddie_NFT"with symbol"GDNFT", creating inconsistency.
@> constructor() ERC721("Goddie_NFT", "GDNFT") {}
Risk
Likelihood:
-
Name inconsistency exists for all deployed instances
-
Users and integrators will notice the mismatch
Impact:
-
Brand confusion and unprofessional appearance
-
Potential trust issues due to inconsistent naming
Proof of Concept
function test_LOW_InconsistentContractName() public {
// Contract is named BidBeasts but ERC721 name is "Goddie_NFT"
string memory contractName = nft.name();
string memory contractSymbol = nft.symbol();
assertEq(contractName, "Goddie_NFT", "Contract name is inconsistent");
assertEq(contractSymbol, "GDNFT", "Contract symbol is inconsistent");
// This is a branding/naming inconsistency issue
assertTrue(
keccak256(bytes(contractName)) != keccak256(bytes("BidBeasts")),
"Contract name should match the contract class name"
);
}
Recommended Mitigation
- constructor() ERC721("Goddie_NFT", "GDNFT") {}
+ constructor() ERC721("BidBeasts", "BBEAST") {}
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.